feat!: run the generator #2096
Merged
feat!: run the generator #2096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #2096 +/- ##
==========================================
- Coverage 49.58% 49.51% -0.08%
==========================================
Files 9 9
Lines 1341 1339 -2
Branches 21 20 -1
==========================================
- Hits 665 663 -2
Misses 676 676
Continue to review full report at Codecov.
|
bcoe
approved these changes
May 13, 2020
|
@JustinBeckwith do we want to merge this, or would we rather wait until tomorrow morning and see if the generation works. |
|
Partner team is asking for it, so lets get this in. I'm sure there will be changes tomorrow :) |
Merged
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
May 13, 2020
🤖 I have created a release \*beep\* \*boop\* --- ## [51.0.0](https://www.github.com/googleapis/google-api-nodejs-client/compare/v50.0.0...v51.0.0) (2020-05-13) ### ⚠ BREAKING CHANGES * run the generator (#2096) ### Features * generate samples ([#2056](https://www.github.com/googleapis/google-api-nodejs-client/issues/2056)) ([ea599ac](https://www.github.com/googleapis/google-api-nodejs-client/commit/ea599acb1a5adfdfe4efefdf701f19cc07963b70)) * run the generator ([#2096](https://www.github.com/googleapis/google-api-nodejs-client/issues/2096)) ([a89ca06](https://www.github.com/googleapis/google-api-nodejs-client/commit/a89ca0677d79c3dd0376459de77bdad3118d3f44)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
|
Why is this a breaking change? Would be nice if the changelog had more info then 'run the generator' for breaking changes. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.