OAuth2Client shouldn't throw access token error until attempting to refresh #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
rakyll
pushed a commit
that referenced
this pull request
Jun 24, 2013
OAuth2Client shouldn't throw access token error until attempting to refresh
|
d826c3a fixes this issue, the exception is now thrown unless an access or a refresh token is provided. |
|
Looks great, thank you! |
This was referenced Dec 24, 2020
This was referenced Sep 6, 2021
This was referenced Jan 12, 2022
This was referenced Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Line 159 of lib/auth/oauth2client.js throws an error if no access token is present, but if a refresh token is present in credentials, an attempt to obtain an access token with the refresh token should be made before failing.