Allow any Google cloud endpoint to be used #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allow any Google cloud endpoints to be used.
|
|
||
| var rootUrl = url.parse(this.apiMeta.rootUrl), | ||
| callback = this.handleResponse(opt_callback), | ||
| requestOpts = this.generatePayload(rootUrl.protocol + '//' + rootUrl.host); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Some tests are failing because of the change. |
|
O' just notice the test, will check. |
|
tests should be ok now. |
| @@ -290,7 +293,7 @@ BatchRequest.prototype.generatePayload = function() { | |||
|
|
|||
| return { | |||
| method: 'POST', | |||
| uri: BaseRequest.BASE_URL + '/batch', | |||
| uri: rootUrl + '/batch', | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
rakyll
pushed a commit
that referenced
this pull request
Aug 5, 2013
Allow any Google cloud endpoint to be used
This was referenced Dec 24, 2020
This was referenced Sep 6, 2021
This was referenced Jan 12, 2022
This was referenced Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code allow you to load discovery documents from your own Google cloud endpoint.
There was a bug in the code that always assumed that the base url is https://www.googleapis.com and not the one that you used to create the discovery document.