Duplicate objects in GoogleApis.toBeDiscovered #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -107,8 +107,14 @@ GoogleApis.DISCOVERY_PARAMS_ = null; | |||
| * @return {GoogleApis} Returns itself. | |||
| */ | |||
| GoogleApis.prototype.discover = function(name, version, opt_opts) { | |||
| this.toBeDiscovered.push({ | |||
| name: name, version: version, opts: opt_opts }); | |||
| var alreadyDiscovered = this.toBeDiscovered.filter(function(discovery){ | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
It'd also nice to add tests to |
|
Thanks for the pointers, I'll take a shot at some tests shortly. |
|
Thanks, LGTM. |
rakyll
pushed a commit
that referenced
this pull request
Aug 26, 2013
Duplicate objects in GoogleApis.toBeDiscovered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could definitely be fixed on the client side, but since this was the only issue preventing the re-use of the same
googleapisobject with multiple calls to.discover, I thought you might want a PR. I was callinggoogleapis.discover(...)multiple times. Upon executing the request, discovering the same API repeatedly was causing a massive, mysterious slowdown.