Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added warning in the example code refresh token #827

Merged
merged 7 commits into from Mar 6, 2018

Conversation

lucascdsilva
Copy link
Contributor

@lucascdsilva lucascdsilva commented Oct 19, 2017

added warning: in the example code of automatic update of the
token access.

Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for discussion)

  • npm test succeeds
  • Pull request has been squashed into 1 commit
  • I did NOT manually make changes to anything in apis/
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate JSDoc comments were updated in source code (if applicable)
  • Approprate changes to readme/docs are included in PR

added warning: in the example code of automatic update of the
token access.
@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Oct 19, 2017
@codecov-io
Copy link

codecov-io commented Oct 19, 2017

Codecov Report

Merging #827 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #827   +/-   ##
=======================================
  Coverage   79.23%   79.23%           
=======================================
  Files           4        4           
  Lines         236      236           
  Branches       53       53           
=======================================
  Hits          187      187           
  Misses         30       30           
  Partials       19       19
Impacted Files Coverage Δ
lib/apirequest.ts 97.26% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb16bed...9055b11. Read the comment docs.

@lucascdsilva
Copy link
Contributor Author

i signed (CLA)

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Oct 30, 2017
README.md Outdated
@@ -258,6 +258,10 @@ The following sample retrieves Google+ profile of the authenticated user.
var google = require('googleapis');
var plus = google.plus('v1');
var OAuth2 = google.auth.OAuth2;

// WARNING: it's important to keep filled YOUR_CLIENT_ID,
// YOUR_CLIENT_SECRET, YOUR_REDIRECT_URL for for use automatically refreshed

This comment was marked as spam.

This comment was marked as spam.

@JustinBeckwith JustinBeckwith merged commit 0f4d4e4 into googleapis:master Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants