Upgrade to the latest google-auth-library #891
Conversation
googlebot
added
the
cla: yes
test/test.options.ts
Outdated
| assert.notEqual( | ||
| query.indexOf('myParam=123'), -1, 'Default param not found in query'); | ||
| done(); | ||
| nock.enableNetConnect(); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
LGTM but please take a look at the CI error |
src/lib/apirequest.ts
Outdated
| // || defaultMime, body: media.body // can be a readable stream or | ||
| // raw string! | ||
| // } | ||
| // ]; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
src/lib/apirequest.ts
Outdated
| options.json = resource || | ||
| ((options.method === 'GET' || options.method === 'DELETE') ? true : {}); | ||
| options.data = resource || undefined; | ||
| //((options.method === 'GET' || options.method === 'DELETE') ? true : |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| const finale = `--${boundary}--`; | ||
| const rStream = new stream.PassThrough(); | ||
| const isStream = isReadableStream(multipart[1].body); | ||
| headers['Content-Type'] = `multipart/related; boundary=${boundary}`; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
src/lib/discovery.ts
Outdated
| return (cb) => { | ||
| self.discoverAPI(api.discoveryRestUrl, (e, newApi) => { | ||
| transporter.request<DiscoverAPIsResponse>( | ||
| {url: discoveryUrl, headers}, (err, resp) => { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
src/lib/discovery.ts
Outdated
| return handleError(err, callback); | ||
| } | ||
| const items = resp.data.items; | ||
| async.parallel( |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
test/test.media.ts
Outdated
| @@ -3,7 +3,7 @@ | |||
| // you may not use this file except in compliance with the License. | |||
| // You may obtain a copy of the License at | |||
| // | |||
| // http://www.apache.org/licenses/LICENSE-2.0 | |||
| // http://www.apache.o rg/licenses/LICENSE-2.0 | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| it('should keep query params as is', (done) => { | ||
| const p = '/drive/v2/files/123abc?hello=world'; | ||
| nock(Utils.baseUrl).get(p).reply(200); | ||
| localDrive.files.get({fileId: '123abc', hello: 'world'}, (err, res) => { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
test/test.transporters.ts
Outdated
| testContentType(localDrive); | ||
| testContentType(remoteDrive); | ||
| it('should automatically add content-type for POST requests', async () => { | ||
| return Promise.all( |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
JustinBeckwith
changed the title
The latest version of the google-auth-library makes a few breaking changes.
Note - this is ready! Please take another look if interested :)