change to make youtube video insertion work #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -190,6 +190,7 @@ Request.prototype.generateBody = function(rootUrl) { | |||
| */ | |||
| Request.prototype.generateUploadBody = function(rootUrl) { | |||
| var params = this.params || {}; | |||
| if (rootUrl.slice(-1) === "/") rootUrl = rootUrl.slice(0, -1); | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Thanks for the PR, I also filled #93 for the longer term improvement. |
|
Good point, thanks. I've made the edit you suggested. |
rakyll
pushed a commit
that referenced
this pull request
Oct 17, 2013
change to make youtube video insertion work
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API discovery gives a rootUrl for youtube video insertion with a trailing slash. Appending "/upload" to that in Request.prototype.generateUploadBody results in a request that gets rejected by YouTube. I'm not sure if "/upload" should be "upload" or if the rootUrl returned by discovery should not have a trailing slash. In either case, this non-destructive change resolves the symptom.