release 25.0.0 #932
Merged
release 25.0.0 #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
Right now something is up with Travis, but even before that - CI seemed to be broken for Node.js 4 and 6. Usually this means there was an update in some sort of transitive dependency, and not having a package-lock.json (like we do in 8 and 9) has bitten us. I haven't had time to debug the issue, but I think that's something we should do before cutting a release. |
|
I'll take a look. Also, do you mind changing travis to circle for this repo? I can do that. |
|
I wouldn't mind at all. Thank you :) That and setting up automatic releases were on the list. |
|
Can we separate the move to CircleCI and this release? Would be nice to see CircleCI pass, and then ship the release :) |
|
OK :) |
JustinBeckwith
approved these changes
Jan 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Releasing v25.0.0.