Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add test for typescript d.ts #958

Merged
merged 1 commit into from
Jan 25, 2018
Merged

test: add test for typescript d.ts #958

merged 1 commit into from
Jan 25, 2018

Conversation

JustinBeckwith
Copy link
Contributor

Adds a test to ensure our d.ts generation is actually working and usable. Addresses #956.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 25, 2018
@alexander-fenster
Copy link
Contributor

Looks like something is still wrong with tests here.

@JustinBeckwith
Copy link
Contributor Author

All fixed up :)

@alexander-fenster alexander-fenster merged commit e6f2a5d into googleapis:master Jan 25, 2018
@JustinBeckwith JustinBeckwith deleted the 956 branch March 11, 2018 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-fenster alexander-fenster alexander-fenster approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JustinBeckwith @alexander-fenster @googlebot