feat: reduce package file size

[bshaffer]

Reduces the package file size by doing the following:

• Puts PHP docs on one line
• Puts all model files in model.php

Testing on the branch consolidate-models-gen, with just these two changes, we get a reduction of 99M to 44M:

$ composer require google/apiclient-services 
Using version ^0.275.0 for google/apiclient-services
$ du -sh vendor/google/apiclient-services
 99M	vendor/google/apiclient-services

$ composer require google/apiclient-services:dev-consolidate-models-gen
$ du -sh  vendor/google/apiclient-services
 44M	vendor/google/apiclient-services

That's a reduction of 56% file size (55MB)!!

TODO: Verify what composer pulls down and check the size there

NOTE: My testing removed RemoteBuildExecution, SemanticTile, AdExchangeBuyer, Webmasters, and PlayableLocations

Other consideration

• When protected $xyzDataType = '', don't create the property, as it's functionally equivalent to the property not existing (see Model::__get).
• Remove class_alias calls (they've been around for a year and a half now)

Other OTHER considerations (not related to package file size)

• Move Service classes inside Service directory
• Add an "unofficial" mirror repo for creating the composer packages (e.g. googlemirror/apiclient-mybusinessqa)

[conventional-commit-lint-gcf]

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

[ejunker]

I could really use this. I am only using 1 Google service and I am using an NFS mounted filesystem that is shared between my web servers. Sometimes when installing an updated version of this package I run into a timeout because it takes so long to write all these small files. I know that is not your problem but reducing the size and number of files would be beneficial to many people.

[bshaffer]

Hello @ejunker !
On second thought, reducing the package size by removing things like repeated blocks of code probably won't reduce the time to install the package. This is because git uses compression algorithms which should already be optimized to take care of such things.
If you can definitively say the changes in this PR solve your issue, then I'm happy to merge and release this. However, unless we are confident this would alleviate the issue, I think we need to look for a better solution.

Please test using this branch (you can do so by running composer require google/apiclient-services:dev-consolidate-models-gen on your NFS) and let me know if you see a substantial difference. Thank you!

[ejunker]

Here are some benchmarks I did:
original version: 6 minutes 22 seconds
your consolidate-models-gen branch: 1 minute 10 seconds

I ended up creating my own fork of the package with only the files I need. When I install that package it only takes 2 seconds!

This is what my composer.json looks like:

    "require": {
        "google/apiclient-services": "dev-main as v0.292.0"
    },
    "repositories": [
        {
            "type": "vcs",
            "url": "git@github.com:ejunker/google-indexing.git"
        }
    ]

I think I will continue to use my custom fork but it is encouraging to see it drop from 6 minutes down to 1 minute.

[ejunker]

Have you ever thought about creating read-only subtree splits and publishing multiple packages? Many of the PHP frameworks like Laravel and Symfony do this. https://tomasvotruba.com/blog/2017/01/31/how-monolithic-repository-in-open-source-saved-my-laziness/

[bshaffer]

We have thought of it but 250+ new repos for a no longer truly maintained library is not something we can realistically do at the moment. We already do that for our new client libraries here: https://cloud.google.com/php/docs/reference

…

On Tue, Apr 4, 2023, 4:50 PM Eric Junker ***@***.***> wrote: Have you ever thought about creating read-only subtree splits and publishing multiple packages? Many of the PHP frameworks like Laravel and Symfony do this. https://tomasvotruba.com/blog/2017/01/31/how-monolithic-repository-in-open-source-saved-my-laziness/ — Reply to this email directly, view it on GitHub <#1730 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAZMBMCRCJ5IMFQSWJZGNLW7SJTJANCNFSM6AAAAAASHFDGOE> . You are receiving this because you authored the thread.Message ID: ***@***.*** com>