Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: discovery doc caching #110

Closed
tmatsuo opened this issue Jun 29, 2015 · 3 comments · Fixed by #127
Closed

Discussion: discovery doc caching #110

tmatsuo opened this issue Jun 29, 2015 · 3 comments · Fixed by #127
Assignees
Labels
🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@tmatsuo
Copy link
Contributor

tmatsuo commented Jun 29, 2015

discovery.build() is handy, but afaik, it should be avoided in any production systems, especially if the API is considered stable and you should cache the discovery document and re-use it.

When Cloud Pub/Sub released the API version v1, I started to cache (appengine/other) the discovery document in our samples.

It is great if there is a library, or even discovery.build() takes care of all the caching stuff under the cover, so I will start working on either of 1) create an independent library that does caching, or 2) create a PR to google-api-python-client.

Before I proceed, I'd like to ask: Which do you guys prefer?

@tmatsuo
Copy link
Contributor Author

tmatsuo commented Jul 7, 2015

Ping @nathanielmanistaatgoogle
WDYT?

@nathanielmanistaatgoogle
Copy link
Contributor

I'm open to a pull request in this project. Would the public API change at all? Would clients have to behave differently? What are the ways the new behavior could be accidentally misused, and what would the consequences be?

@tmatsuo
Copy link
Contributor Author

tmatsuo commented Jul 17, 2015

There shouldn't be any API changes. All the caching should be done just under the cover.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants