Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix a typo in UPGRADING.md related to static_discovery #1956

Merged
merged 3 commits into from
Oct 27, 2022

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Oct 25, 2022

See the code below

if static_discovery is None:
if discoveryServiceUrl is None:
static_discovery = True
else:
static_discovery = False

This PR proposes that we change the wording in UPGRADING.md from

if `static_discovery` is not
specified, the default value for `static_discovery` will be `True` when
the `discoveryServiceUrl` argument of `discovery.build()` is provided.

to

if `static_discovery` is not
specified, the default value for `static_discovery` will be `False` when
the `discoveryServiceUrl` argument of `discovery.build()` is provided.

@parthea parthea requested a review from a team as a code owner October 25, 2022 15:11
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Oct 25, 2022
@parthea parthea merged commit bc03ac6 into main Oct 27, 2022
@parthea parthea deleted the parthea-patch-3 branch October 27, 2022 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants