Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow users to configure client option universe_domain #2368

Merged
merged 2 commits into from Mar 25, 2024

Conversation

ohmayr
Copy link
Contributor

@ohmayr ohmayr commented Mar 25, 2024

Fixes #2365 馃
Towards b/324211188 馃

@ohmayr ohmayr requested a review from a team as a code owner March 25, 2024 19:11
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Mar 25, 2024
@ohmayr ohmayr force-pushed the allow-users-to-configure-client-option-universe branch from 2de5a3b to 1da7b66 Compare March 25, 2024 19:25
@ohmayr ohmayr added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 25, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 25, 2024
@parthea parthea changed the title feat: Allow users to configure client option universe feat: Allow users to configure client option universe_domain Mar 25, 2024
@ohmayr ohmayr merged commit 359b3ac into main Mar 25, 2024
13 checks passed
@ohmayr ohmayr deleted the allow-users-to-configure-client-option-universe branch March 25, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests for validating credentials for the configured universe once leveraged.
3 participants