Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow users to configure environment variable GOOGLE_CLOUD_UNIVERSE_DOMAIN #2369

Merged
merged 3 commits into from Mar 26, 2024

Conversation

ohmayr
Copy link
Contributor

@ohmayr ohmayr commented Mar 25, 2024

Fixes b/324211188 馃 馃

@ohmayr ohmayr requested a review from a team as a code owner March 25, 2024 19:55
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Mar 25, 2024
@parthea parthea marked this pull request as draft March 25, 2024 19:57
@parthea
Copy link
Contributor

parthea commented Mar 25, 2024

Switching to draft until #2368 is merged

@ohmayr ohmayr changed the title feat: allow users to configure universe environment variable feat: allow users to configure environment variable GOOGLE_CLOUD_UNIVERSE_DOMAIN Mar 25, 2024
@ohmayr ohmayr force-pushed the allow-users-to-configure-env-var-universe branch from 07fa8ba to e08e440 Compare March 25, 2024 20:29
@ohmayr
Copy link
Contributor Author

ohmayr commented Mar 25, 2024

Ready for review since #2368 is now merged.

@ohmayr ohmayr marked this pull request as ready for review March 25, 2024 20:31
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 26, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 26, 2024
@parthea parthea enabled auto-merge (squash) March 26, 2024 15:16
@parthea parthea merged commit 4766fbd into main Mar 26, 2024
13 checks passed
@parthea parthea deleted the allow-users-to-configure-env-var-universe branch March 26, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants