Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(generator): Fix crash when a response doesn't reference a type #13150

Merged
merged 1 commit into from
Jan 2, 2023

Conversation

dazuma
Copy link
Member

@dazuma dazuma commented Dec 29, 2022

Includes two fixes:

  • We include more stringent checks in the generator to handle certain types of malformed discovery docs more gracefully. Specifically, these are methods that don't specify a proper type or specify a nonexistent type for their request or response. As of this writing, integrations_v1 and identitytoolkit_v1 exhibit these kinds of errors.
  • We recover better during a weekly regeneration job if an API does fail generation catastrophically. Instead of causing the entire job to abort prematurely, we just note the error and skip the offending API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant