Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(generator): Support for universe_domain in generated clients #17132

Merged
merged 1 commit into from
Jan 22, 2024
Merged

feat(generator): Support for universe_domain in generated clients #17132

merged 1 commit into from
Jan 22, 2024

Conversation

dazuma
Copy link
Member

@dazuma dazuma commented Jan 17, 2024 •
edited
Loading

This simply:

  • Updates the google-apis-core dependency to a version that supports universe_domain in the base classes
  • Passes an endpoint with a universe domain substitution into the base class instead of the google default universe endpoint.

Depends on #17131 being completed and released.

@dazuma dazuma mentioned this pull request Jan 17, 2024
Closed
@dazuma dazuma marked this pull request as ready for review January 22, 2024 18:15
@dazuma dazuma requested a review from a team as a code owner January 22, 2024 18:15
@dazuma dazuma merged commit 11688f8 into googleapis:main Jan 22, 2024
9 checks passed
@dazuma dazuma deleted the pr/gen-ud branch January 22, 2024 18:31
@release-please release-please bot mentioned this pull request Jan 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bajajneha27 bajajneha27 bajajneha27 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dazuma @bajajneha27