We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When using the library, I found a bug in the UserCredentials#ToBuilder() It's not calling super and therefore we lost the access token
UserCredentialsTest.java @Test public void toBuilder() throws IOException { final URI tokenServer1 = URI.create("https://foo1.com/bar"); AccessToken accessToken = new AccessToken(ACCESS_TOKEN, null); MockHttpTransportFactory httpTransportFactory = new MockHttpTransportFactory(); UserCredentials credentials = UserCredentials.newBuilder() .setClientId(CLIENT_ID) .setClientSecret(CLIENT_SECRET) .setRefreshToken(REFRESH_TOKEN) .setAccessToken(accessToken) .setHttpTransportFactory(httpTransportFactory) .setTokenServerUri(tokenServer1) .build(); credentials.toBuilder().build(); UserCredentials otherCredentials = credentials.toBuilder().build(); assertEquals(credentials, otherCredentials); }
Will shortly provide a PR for this
The text was updated successfully, but these errors were encountered:
googleapis#992 Not loosing the access token when calling UserCredenti…
7783d1a
…als#ToBuilder()
googleapis#992 Implement comments and add some builder setters which …
be45e01
…were missing
Successfully merging a pull request may close this issue.
Environment details
When using the library, I found a bug in the UserCredentials#ToBuilder()
It's not calling super and therefore we lost the access token
Steps to reproduce
Will shortly provide a PR for this
The text was updated successfully, but these errors were encountered: