Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: using full package names to avoid incorrect import merge #1193

Merged
merged 15 commits into from
Apr 7, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .github/.OwlBot.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# Copyright 2021 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

docker:
image: "gcr.io/cloud-devrel-public-resources/owlbot-java:latest"
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@
import com.google.common.base.MoreObjects;
import java.io.IOException;
import java.io.InputStream;
import java.io.Serializable;
import java.math.BigDecimal;
import java.net.URI;
import java.nio.charset.StandardCharsets;
Expand All @@ -69,7 +68,7 @@ public abstract class ExternalAccountCredentials extends GoogleCredentials {
private static final long serialVersionUID = 8049126194174465023L;

/** Base credential source class. Dictates the retrieval method of the external credential. */
abstract static class CredentialSource implements Serializable {
abstract static class CredentialSource implements java.io.Serializable {

private static final long serialVersionUID = 8204657811562399944L;

Expand Down Expand Up @@ -641,7 +640,7 @@ private static boolean isValidUrl(String url) {
* }
* </pre>
*/
static final class ServiceAccountImpersonationOptions implements Serializable {
static final class ServiceAccountImpersonationOptions implements java.io.Serializable {

private static final long serialVersionUID = 4250771921886280953L;
private static final int DEFAULT_TOKEN_LIFETIME_SECONDS = 3600;
Expand Down
3 changes: 1 addition & 2 deletions owlbot.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
".kokoro/nightly/integration.cfg",
".kokoro/presubmit/integration.cfg",
".kokoro/presubmit/graalvm-native.cfg",
".kokoro/presubmit/graalvm-native-17.cfg",
"oauth2_http/java/com/google/auth/oauth2/ExternalAccountCredentials.java"
".kokoro/presubmit/graalvm-native-17.cfg"
]
)
1 change: 0 additions & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,6 @@
<version>2.13</version>
<configuration>
<verbose>true</verbose>
<skipSortingImports>true</skipSortingImports>
</configuration>
</plugin>
<plugin>
Expand Down