Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use metadata server to get credentials for GAE 8 standard environment #122

Merged
merged 2 commits into from Sep 1, 2017

Conversation

neozwu
Copy link
Contributor

@neozwu neozwu commented Aug 30, 2017

GAE java 8 standard environment supports Java native threads. However getDefaultCredentials() call will fail on GAE J8 if it is called in a native thread (i.e. threads not managed by appengine runtime) due to the inaccessibility of native threads to appengine APIs. For GAE java8, same as compute engine, metadata serve should be used to construct Credentials.

@neozwu
Copy link
Contributor Author

neozwu commented Sep 1, 2017

kindly ping @garrettjonesgoogle @lesv

Copy link
Member

@garrettjonesgoogle garrettjonesgoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neozwu neozwu merged commit 60870c9 into googleapis:master Sep 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants