Fix: Make derived classes of CredentialSource public #1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
mario-vimal
force-pushed
the
CredentialSource_public
branch
from
781fb65
to
4c6838e
Compare
mario-vimal
changed the title
lsirac
approved these changes
Jul 12, 2023
|
Please move those classes into separate classes. Nested classes could cause bogus error in the future like we had recently. Once public it would be harder to move them out. @lsirac |
TimurSadykov
requested changes
Jul 13, 2023
|
References to previous problems with nested imports: caused by: |
product-auto-label
bot
added
size: l
mario-vimal
force-pushed
the
CredentialSource_public
branch
from
ebc48ac
to
14e5a78
Compare
aeitzman
reviewed
Jul 14, 2023
aeitzman
reviewed
Jul 14, 2023
lsirac
reviewed
Jul 20, 2023
oauth2_http/java/com/google/auth/oauth2/AwsCredentialSource.java
Outdated
Show resolved
Hide resolved
TimurSadykov
requested changes
Jul 21, 2023
oauth2_http/java/com/google/auth/oauth2/ExternalAccountCredentials.java
Outdated
Show resolved
Hide resolved
lsirac
approved these changes
Jul 24, 2023
aeitzman
approved these changes
Jul 25, 2023
…nnotations to v1.1.1 (googleapis#1253) Co-authored-by: Lawrence Qiu <lqiu96@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently credential source cannot be specified during initialization for AwsCredentials, IdentityPoolCredentials and PluggableAuthCredentials.
The corresponding derived credential sources have been made public for credential creation using credential sources.