Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update library definitions in README to the latest version #1239

Merged
merged 1 commit into from
Jul 21, 2023
Merged

chore: Update library definitions in README to the latest version #1239

merged 1 commit into from
Jul 21, 2023

Conversation

Maxr1998
Copy link
Contributor

@Maxr1998 Maxr1998 commented Jul 16, 2023

I recently switched to this library for a project, and since I just copied the info from the readme I used an ancient version at first. That was especially annoying since many APIs that would've been helpful for me during migration didn't exist back in version 1.3.0 (like creating ServiceAccountCredentials from a PKCS8 string without having to pass JSON).

I'd love to prevent other users from making the same mistake as myself in the future through this README update.

@Maxr1998 Maxr1998 requested review from a team as code owners July 16, 2023 22:15
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jul 16, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@TimurSadykov
Copy link
Member

Thanks for updating this )

Copy link
Member

@TimurSadykov TimurSadykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TimurSadykov TimurSadykov changed the title Update library definitions in README to the latest version chore: Update library definitions in README to the latest version Jul 21, 2023
@TimurSadykov TimurSadykov merged commit 0c5cff2 into googleapis:main Jul 21, 2023
15 checks passed
@Maxr1998 Maxr1998 deleted the update-readme-versions branch July 22, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants