fix: handle error-prone warnings #1334

sinelaw · 2023-11-21T19:16:24Z

ErrorProne flags several issues in the codebase, this pull request fixes some of them:

Missing @Override annotations where needed
Using of deprecated or incompatibel APIs for Base64 encoding

There's also a warning by maven due to conflicting / duplicate dependencies in pom.xml, this is also fixed.

…use warnings This prevents the following errors: $ mvn install -DskipTests=true [INFO] Scanning for projects... [WARNING] [WARNING] Some problems were encountered while building the effective model for com.google.auth:google-auth-library-oauth2-http:jar:1.20.1-SNAPSHOT [WARNING] 'dependencies.dependency.(groupId:artifactId:type:classifier)' must be unique: junit:junit:jar -> duplicate declaration of version (?) @ line 249, column 17 [WARNING] 'build.plugins.plugin.(groupId:artifactId)' must be unique but found duplicate declaration of plugin org.apache.maven.plugins:maven-failsafe-plugin @ line 193, column 15 [WARNING] [WARNING] It is highly recommended to fix these problems because they threaten the stability of your build. [WARNING] [WARNING] For this reason, future Maven versions might no longer support building such malformed projects. [WARNING]

ejona86 · 2023-11-22T16:28:15Z

The Base64 thing is about Android compatibility.

sinelaw · 2023-11-22T16:52:06Z

The Base64 thing is about Android compatibility.

Indeed, but it also triggers error prone on https://errorprone.info/bugpattern/AndroidJdkLibsChecker

ejona86 · 2023-11-22T19:22:41Z

The Base64 thing is about Android compatibility.

Indeed, but it also triggers error prone on https://errorprone.info/bugpattern/AndroidJdkLibsChecker

Yet the proper solution in many projects is to turn off the check. API desugaring supports this on Android. For a library, it's mostly a question if you require your users to use API desugaring.

You can avoid the API or use it. The point is that it is a decision that is not made "because Error Prone complained." Error Prone is well beyond the "only tell you about highly likely bugs" that it set out to be. You have to tweak and tune it to your usages and be willing to add ignores (as has been repeated to me multiple times when I complained that a suggestion was encouraging security vulnerabilities or was wrong). And some of this is auto-configured inside Google; sometimes an warning means you have a configuration mistake, not a code mistake.