Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Modify the refresh window to match go/async-token-refresh. Serverless tokens are cached until 4 minutes before expiration, so 4 minutes is the ideal refresh window. #1352

Merged
merged 3 commits into from Jan 11, 2024
Merged

feat: Modify the refresh window to match go/async-token-refresh. Serverless tokens are cached until 4 minutes before expiration, so 4 minutes is the ideal refresh window. #1352

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ead2ba
feat: Modify the refresh window to match go/async-token-refresh. Serv…
clundin25 Jan 10, 2024
d1ade54
Tweak time to 3 minutes and 45 seconds, giving the MDS a 15 second wi…
clundin25 Jan 10, 2024
b58505a
Update both expiration margin and refresh margin.
clundin25 Jan 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions oauth2_http/java/com/google/auth/oauth2/OAuth2Credentials.java
View file
Open in desktop
Expand Up @@ -68,8 +68,8 @@
public class OAuth2Credentials extends Credentials {

private static final long serialVersionUID = 4556936364828217687L;
static final Duration DEFAULT_EXPIRATION_MARGIN = Duration.ofMinutes(5);
static final Duration DEFAULT_REFRESH_MARGIN = Duration.ofMinutes(6);
static final Duration DEFAULT_EXPIRATION_MARGIN = Duration.ofMinutes(3);
static final Duration DEFAULT_REFRESH_MARGIN = Duration.ofMinutes(3).plusSeconds(45);
private static final ImmutableMap<String, List<String>> EMPTY_EXTRA_HEADERS = ImmutableMap.of();

@VisibleForTesting private final Duration expirationMargin;
Expand Down