Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Issue #1347: ExternalAccountCredentials serialization is broken #1358

Merged
merged 6 commits into from
Jan 24, 2024
Merged

fix: Issue #1347: ExternalAccountCredentials serialization is broken #1358

merged 6 commits into from
Jan 24, 2024

Conversation

BigTailWolf
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1347: ExternalAccountCredentials serialization is broken

If you write sample code, please follow the samples format.

@BigTailWolf BigTailWolf requested review from a team as code owners January 24, 2024 00:35
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Jan 24, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 24, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

TimurSadykov
TimurSadykov approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@TimurSadykov TimurSadykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lsirac lsirac added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 24, 2024
@BigTailWolf BigTailWolf merged commit e3a2e9c into googleapis:main Jan 24, 2024
18 of 19 checks passed
@release-please release-please bot mentioned this pull request Jan 22, 2024
Merged
@BigTailWolf BigTailWolf mentioned this pull request Jan 24, 2024
Merged
@BigTailWolf BigTailWolf deleted the b317995693 branch February 21, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimurSadykov TimurSadykov TimurSadykov approved these changes

@lsirac lsirac lsirac approved these changes

Assignees
No one assigned
Labels
do not merge Indicates a pull request not ready for merge, due to either quality or timing. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ExternalAccountCredentials serialization is broken
3 participants
@BigTailWolf @TimurSadykov @lsirac