Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix CI errors on javadoc #1422

Merged
merged 5 commits into from
Jun 10, 2024
Merged

Conversation

BigTailWolf
Copy link
Contributor

@BigTailWolf BigTailWolf commented Jun 7, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@BigTailWolf BigTailWolf requested review from a team as code owners June 7, 2024 22:37
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Jun 7, 2024
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: m Pull request size is medium. labels Jun 7, 2024
@@ -268,7 +268,8 @@ public Builder setAwsSecurityCredentialsSupplier(
* Sets the AWS regional credential verification URL. If set, will override any credential
* verification URL provided in the credential source. If not set, the credential verification
* URL will default to
* https://sts.{region}.amazonaws.com?Action=GetCallerIdentity&Version=2011-06-15"
*
* <p><a href=https://sts.{region}.amazonaws.com?Action=GetCallerIdentity&Version=2011-06-15>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@BigTailWolf BigTailWolf Jun 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was not intentionally using <p>, let me try to remove it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmmm. lint is doesn't allow me to remove it and failed. Adding a closing tag also failed it.

Copy link

sonarcloud bot commented Jun 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@BigTailWolf BigTailWolf merged commit ecc754a into googleapis:main Jun 10, 2024
18 checks passed
@BigTailWolf BigTailWolf deleted the b345835174 branch June 10, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants