Add OAuth2Credentials#refreshIfExpired() #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustinBeckwith
approved these changes
Jun 26, 2018
Merged
davidxia
added a commit
to spotify/helios
that referenced
this pull request
Aug 17, 2018
We were mistakenly calling `GoogleCredentials.refreshAccessToken()` which always makes a call to retrieve a new access token regardless of expiration. In addition, this method returns an `AccessToken` which we accidentally ignored. But this method but never sets the `AccessToken` for the `getAccessToken()` method which we subsequently called. Instead, we should use `GoogleCredentials.refreshIfExpired()` which refreshes the token if only if it's close to expiring and returns void. Our next call to `getAccessToken()` will actually return the refreshed token in this case. See googleapis/google-auth-library-java#163
davidxia
added a commit
to spotify/helios
that referenced
this pull request
Aug 17, 2018
We were mistakenly calling `GoogleCredentials.refreshAccessToken()` which always makes a call to retrieve a new access token regardless of expiration. In addition, this method returns an `AccessToken` which we accidentally ignored. But this method but never sets the `AccessToken` for the `getAccessToken()` method which we subsequently called. Instead, we should use `GoogleCredentials.refreshIfExpired()` which refreshes the token if only if it's close to expiring and returns void. Our next call to `getAccessToken()` will actually return the refreshed token in this case. See googleapis/google-auth-library-java#163
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds instance method to explicitly refresh OAuth2Credentials if they need fetching or refreshing.
#143
#147