Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup ImpersonatedCredentials #212

Merged
merged 4 commits into from Nov 14, 2018
Merged

Cleanup ImpersonatedCredentials #212

merged 4 commits into from Nov 14, 2018

Conversation

chingor13
Copy link
Contributor

@chingor13 chingor13 commented Nov 14, 2018

  • Only use a single private constructor
  • Caught and wrapped exceptions now provide better message and set the original error as the cause
  • Various documentation fixes

@chingor13 chingor13 requested a review from a team as a code owner November 14, 2018 22:26
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 14, 2018
@codecov-io
Copy link

codecov-io commented Nov 14, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@b037146). Click here to learn what that means.
The diff coverage is 91.17%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #212   +/-   ##
=========================================
  Coverage          ?   76.86%           
  Complexity        ?      327           
=========================================
  Files             ?       21           
  Lines             ?     1465           
  Branches          ?      158           
=========================================
  Hits              ?     1126           
  Misses            ?      260           
  Partials          ?       79
Impacted Files Coverage Δ Complexity Δ
...om/google/auth/oauth2/ImpersonatedCredentials.java 84.54% <91.17%> (ø) 11 <7> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b037146...1eead32. Read the comment docs.

@chingor13 chingor13 merged commit 8225b92 into googleapis:master Nov 14, 2018
@chingor13 chingor13 deleted the impersonated-cleanup branch July 11, 2019 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants