Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies versions #234

Merged
merged 2 commits into from
Mar 25, 2019
Merged

Update dependencies versions #234

merged 2 commits into from
Mar 25, 2019

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Mar 25, 2019

This moves Guava and AppEngine API SDK forward.
It resolves a minor inconsistency in the version definition for the AppEngine API SDK.
It also moves the google-http-java-client backwards to 1.27.0 because 1.28.0 made an incompatible change that breaks google-cloud-java (which depends on 1.27.0) and using 1.28.0 here risks runtime problems down the line.

@elharo elharo requested a review from a team as a code owner March 25, 2019 12:49
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 25, 2019
@elharo
Copy link
Contributor Author

elharo commented Mar 25, 2019

It's possible the "Kokoro - Test: Java 8" job is wedged somehow or not reporting status. Both this PR and the much simpler #233 have been stuck at "Expected — Waiting for status to be reported" for a while now.

@sduskis sduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 25, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 25, 2019
@codecov
Copy link

codecov bot commented Mar 25, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@5db7702). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #234   +/-   ##
=========================================
  Coverage          ?   78.26%           
  Complexity        ?      329           
=========================================
  Files             ?       21           
  Lines             ?     1445           
  Branches          ?      158           
=========================================
  Hits              ?     1131           
  Misses            ?      236           
  Partials          ?       78

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5db7702...077e643. Read the comment docs.

Copy link
Contributor Author

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I don't have permission to merge this one. Please merge when you get a minute.

@sduskis sduskis merged commit f1b1c73 into googleapis:master Mar 25, 2019
@JesseLovelace JesseLovelace mentioned this pull request Mar 25, 2019
@elharo elharo deleted the deps branch July 17, 2019 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants