Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use StandardCharsets.UTF_8 constant #532

Merged
merged 5 commits into from Jan 5, 2021
Merged

refactor: use StandardCharsets.UTF_8 constant #532

merged 5 commits into from Jan 5, 2021

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Dec 29, 2020

@elharo elharo requested a review from a team as a code owner December 29, 2020 19:51
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 29, 2020
@codecov
Copy link

codecov bot commented Dec 29, 2020

Codecov Report

Merging #532 (6d807e9) into master (ecfc6a2) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #532      +/-   ##
============================================
- Coverage     80.06%   80.05%   -0.02%     
  Complexity      421      421              
============================================
  Files            28       28              
  Lines          1966     1965       -1     
  Branches        209      209              
============================================
- Hits           1574     1573       -1     
  Misses          283      283              
  Partials        109      109              
Impacted Files Coverage Δ Complexity Δ
..._http/java/com/google/auth/oauth2/OAuth2Utils.java 66.66% <ø> (-0.55%) 12.00 <0.00> (ø)
...java/com/google/auth/oauth2/GoogleCredentials.java 61.36% <100.00%> (ø) 10.00 <0.00> (ø)
.../google/auth/oauth2/ServiceAccountCredentials.java 82.44% <100.00%> (ø) 49.00 <0.00> (ø)
...uth/oauth2/ServiceAccountJwtAccessCredentials.java 75.64% <100.00%> (ø) 40.00 <0.00> (ø)
...p/java/com/google/auth/oauth2/UserCredentials.java 80.28% <100.00%> (ø) 32.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecfc6a2...6d807e9. Read the comment docs.

@chingor13 chingor13 changed the title chore: there's now a UTF-8 constant in the JDK refactor: use StandardCharsets.UTF_8 constant Dec 30, 2020
@chingor13 chingor13 added the automerge Merge the pull request once unit tests and other checks pass. label Dec 30, 2020
@elharo elharo merged commit a8697f7 into master Jan 5, 2021
@elharo elharo deleted the utf branch January 5, 2021 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants