Modify DefaultCredentialsProvider to use reflection to access AE SDK #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Guys any comment on this? |
|
@garrettjonesgoogle and I should both review this. I will review it today. |
anthmgoogle
approved these changes
Oct 17, 2016
| * <p>Needed instead of constructor version to be compatible with JDK 1.5 which is required | ||
| * until Andriod libraries can update to JDK 1.6 | ||
| */ | ||
| static <T extends Throwable> T exceptionWithCause(T exception, Throwable cause) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
That other change looks good. I'm still LGTM on this one. |
mziccard
force-pushed
the
appengine-reflection
branch
from
6ec89bb
to
72214fb
Compare
|
@anthmgoogle I rebased to catch latest changes. @garrettjonesgoogle do you also want to have a look? |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
OAuth2Utils.exceptionWithCause, use exception costructor insteadAppEngineCredentialstogoogle-auth-library-oauth2-httpthat uses reflection to access AE SDKDefaultCredentialsProviderto instantiate the newAppEngineCredentialsclass/cc @garrettjonesgoogle @anthmgoogle