Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove createScopedRequired and createScope methods #264

Closed
JustinBeckwith opened this issue Jan 23, 2018 · 2 comments
Closed

Remove createScopedRequired and createScope methods #264

JustinBeckwith opened this issue Jan 23, 2018 · 2 comments
Assignees
@JustinBeckwith
Labels
semver: major Hint for users that this is an API breaking change. type: cleanup An internal cleanup or hygiene concern.
Milestone
3.0

Comments

@JustinBeckwith
Copy link
Contributor

Part of the feedback in #55 was to re-rationalize the createScopedRequired and createScope methods. I wrote #255 to try addressing this, but it was way too early for a semver major change after going 1.0.
This was referenced Jan 23, 2018
Closed
Closed
@JustinBeckwith JustinBeckwith mentioned this issue Mar 10, 2018
Merged
@JustinBeckwith JustinBeckwith self-assigned this Mar 10, 2018
@JustinBeckwith
Copy link
Contributor Author

resolved by #318

@JustinBeckwith JustinBeckwith added this to the 2.0 milestone Mar 22, 2018
@JustinBeckwith JustinBeckwith added type: cleanup An internal cleanup or hygiene concern. semver: major Hint for users that this is an API breaking change. labels Jun 22, 2018
@JustinBeckwith JustinBeckwith removed their assignment Jun 28, 2018
@JustinBeckwith JustinBeckwith modified the milestones: 2.0, 3.0 Jul 6, 2018
@JustinBeckwith
Copy link
Contributor Author

We'll get to this when we get to it 🤷‍♂️

@JustinBeckwith JustinBeckwith self-assigned this Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JustinBeckwith JustinBeckwith

Labels
semver: major Hint for users that this is an API breaking change. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
1 participant
@JustinBeckwith