feat: get rid of createScopedRequired #318

JustinBeckwith · 2018-03-10T05:10:00Z

Resolves #264

JustinBeckwith · 2018-03-10T05:10:49Z

I am very confused and do not know why its showing all these commits. "get rid of createScopedRequired" should be the only one.

codecov-io · 2018-03-10T05:11:38Z

Codecov Report

Merging #318 into next will increase coverage by 0.24%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##            next     #318      +/-   ##
=========================================
+ Coverage   94.6%   94.84%   +0.24%     
=========================================
  Files         14       14              
  Lines        853      854       +1     
  Branches     193      199       +6     
=========================================
+ Hits         807      810       +3     
+ Misses        46       44       -2

Impacted Files	Coverage Δ
src/auth/jwtaccess.ts	`98.03% <ø> (-0.08%)`	⬇️
src/auth/iam.ts	`100% <ø> (+25%)`	⬆️
src/auth/computeclient.ts	`93.93% <ø> (-0.35%)`	⬇️
src/auth/googleauth.ts	`94.71% <100%> (+0.2%)`	⬆️
src/auth/jwtclient.ts	`95.18% <100%> (-0.12%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 143f167...84cf775. Read the comment docs.

test/test.googleauth.ts

@@ -1229,6 +1230,13 @@ it('should accept credentials to get a client', async () => {
  assert.equal(client.email, 'hello@youarecool.com');
 });

+it('should allow passing scopes to get a client', async () => {
+  const scopes = ['http://examples.com/is/a/scope'];


README.md

@@ -52,12 +52,14 @@ Rather than manually creating an OAuth2 client, JWT client, or Compute client, t

 For example, a JWT auth client will be created when your code is running on your local developer machine, and a Compute client will be created when the same code is running on Google Cloud Platform.

-The code below shows how to retrieve a default credential type, depending upon the runtime environment. The createScopedRequired must be called to determine when you need to pass in the scopes manually, and when they have been set for you automatically based on the configured runtime environment.
+The code below shows how to retrieve a default credential type, depending upon the runtime environment.


**BREAKING CHANGE**: Renames the `credential` field on the `ADCResponse` to `client`. Previous code like this: ```js const res = await auth.getApplicationDefault(); const client = res.credential; ``` Now will look like this: ```js const res = await auth.getApplicationDefault(); const client = res.client; ```

**BREAKING CHANGE**: Many methods that previously returned `null` may now return `undefined`. We had types that were optional or null all over the codebase. Cleaned this up by removing any null type that was already optional.

**BREAKING CHANGE**: Renames the `credential` field on the `ADCResponse` to `client`. Previous code like this: ```js const res = await auth.getApplicationDefault(); const client = res.credential; ``` Now will look like this: ```js const res = await auth.getApplicationDefault(); const client = res.client; ```

test/test.googleauth.ts

@@ -1233,6 +1233,13 @@ it('should allow passing scopes to get a client', async () => {
  assert.equal(client.scopes, scopes);
 });

+it('should allow passing a scope to get a client', async () => {


test/test.googleauth.ts

+  assert.equal(client.scopes, scopes);
+});
+
+it('should allow passing a scope to get a client', async () => {


googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 10, 2018

JustinBeckwith requested review from ofrobots, jinwoo and a team March 10, 2018 05:10

jinwoo approved these changes Mar 12, 2018

View reviewed changes

JustinBeckwith and others added 9 commits March 12, 2018 18:22

fix: limit situations where we retry (#307)

0772e88

chore: prefer undefined over null (#309)

3c448a1

**BREAKING CHANGE**: Many methods that previously returned `null` may now return `undefined`. We had types that were optional or null all over the codebase. Cleaned this up by removing any null type that was already optional.

chore: improve tests (#308)

a3d6a46

chore: improve tests (#308)

04d20ed

feat: get rid of createScopedRequired

c2e89f4

pr feedback

376f026

fixup

84cf775

jinwoo approved these changes Mar 13, 2018

View reviewed changes

test/test.googleauth.ts Outdated

@@ -1233,6 +1233,13 @@ it('should allow passing scopes to get a client', async () => {

assert.equal(client.scopes, scopes);

});

it('should allow passing a scope to get a client', async () => {

This comment was marked as spam.

Sign in to view

jinwoo approved these changes Mar 13, 2018

View reviewed changes

test/test.googleauth.ts

assert.equal(client.scopes, scopes);

});

it('should allow passing a scope to get a client', async () => {

This comment was marked as spam.

Sign in to view

JustinBeckwith merged commit 5e0a967 into googleapis:next Mar 13, 2018

JustinBeckwith mentioned this pull request Mar 13, 2018

Remove createScopedRequired and createScope methods #264

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: get rid of createScopedRequired #318

feat: get rid of createScopedRequired #318

JustinBeckwith commented Mar 10, 2018 •

edited

Loading

JustinBeckwith commented Mar 10, 2018

codecov-io commented Mar 10, 2018 •

edited

Loading

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

feat: get rid of createScopedRequired #318

feat: get rid of createScopedRequired #318

Conversation

JustinBeckwith commented Mar 10, 2018 • edited Loading

JustinBeckwith commented Mar 10, 2018

codecov-io commented Mar 10, 2018 • edited Loading

Codecov Report

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

JustinBeckwith commented Mar 10, 2018 •

edited

Loading

codecov-io commented Mar 10, 2018 •

edited

Loading