Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tokenUrl override #280

Closed
JustinBeckwith opened this issue Feb 8, 2018 · 2 comments
Closed

Remove tokenUrl override #280

JustinBeckwith opened this issue Feb 8, 2018 · 2 comments
Assignees
@JustinBeckwith
Labels
semver: major Hint for users that this is an API breaking change. type: cleanup An internal cleanup or hygiene concern.
Milestone
2.0

Comments

@JustinBeckwith
Copy link
Contributor

There's a tokenUrl config setting that makes it hard to use gcp-metadata to request tokens in the ComputeClient:
https://github.com/google/google-auth-library-nodejs/blob/master/src/auth/computeclient.ts#L69

We should remove this code, and switch over to using gcp-metadata for all communication in the client.
@JustinBeckwith JustinBeckwith mentioned this issue Feb 13, 2018
Closed
@JustinBeckwith JustinBeckwith self-assigned this Mar 10, 2018
@JustinBeckwith JustinBeckwith mentioned this issue Mar 10, 2018
Merged
@JustinBeckwith
Copy link
Contributor Author

Resolved by #319

@JustinBeckwith JustinBeckwith added this to the 2.0 milestone Mar 22, 2018
@JustinBeckwith JustinBeckwith added type: cleanup An internal cleanup or hygiene concern. semver: major Hint for users that this is an API breaking change. labels Jun 22, 2018
@JustinBeckwith
Copy link
Contributor Author

Covered in #409

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JustinBeckwith JustinBeckwith

Labels
semver: major Hint for users that this is an API breaking change. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
1 participant
@JustinBeckwith