fix: use gcp-metadata for compute credentials #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #409 +/- ##
==========================================
- Coverage 94.93% 94.89% -0.04%
==========================================
Files 15 15
Lines 967 960 -7
Branches 224 218 -6
==========================================
- Hits 918 911 -7
Misses 49 49
Continue to review full report at Codecov.
|
kjin
approved these changes
Jul 6, 2018
src/auth/computeclient.ts
Outdated
| export class Compute extends OAuth2Client { | ||
| private serviceAccountEmail: string; | ||
|
|
||
| // Google Compute Engine metadata server token endpoint. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -18,7 +18,7 @@ import assert from 'assert'; | |||
| import child_process from 'child_process'; | |||
| import crypto from 'crypto'; | |||
| import * as fs from 'fs'; | |||
| import {BASE_PATH, HEADER_NAME, HOST_ADDRESS} from 'gcp-metadata'; | |||
| import {BASE_PATH, HEADERS, HOST_ADDRESS} from 'gcp-metadata'; | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: The
OAuth2Client,JWT, andComputeclasses no longer accept parameters to override the authBaseUrl and tokenUrl. These properties were largely available for testing, but there are better ways to test.Old code
New code