-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
samples: update TODO section #1218
Conversation
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
@googleapis/yoshi-nodejs PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One issue with the snippet we should discuss - also, please use docs:
or samples:
- when you use fix:
, it signals to the release tooling that this should cause a release. This PR doesn't have any material impact on the library code, so we wouldn't want to do that.
samples/idtokens-serverless.js
Outdated
@@ -29,14 +29,15 @@ function main( | |||
* TODO(developer): Uncomment these variables before running the sample. | |||
*/ | |||
// const url = 'https://TARGET_URL'; | |||
// const targetAudience = null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As written, this code would fail because we're using a const
instead of let
, and trying to assign down on line 40. Would another option here be moving const {URL} = require('url');
with the other requires, and always doing the assignment of const targetAudience = new URL(url)
on line 32?
* fix: update TODO section * remove origin * Update idtokens-serverless.js
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 馃