Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Unify Base AuthClient Options #1663

Merged
merged 31 commits into from Oct 26, 2023
Merged

feat: Unify Base AuthClient Options #1663

merged 31 commits into from Oct 26, 2023

Conversation

danielbankhead
Copy link
Member

Also, expose Transporter options

Fixes #1621 🦕

@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Oct 6, 2023
@danielbankhead danielbankhead marked this pull request as ready for review October 10, 2023 02:17
@danielbankhead danielbankhead requested review from a team as code owners October 10, 2023 02:17
@danielbankhead danielbankhead added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Oct 10, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 10, 2023
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Oct 10, 2023
This was referenced Oct 12, 2023
Open
Open
Open
@danielbankhead danielbankhead mentioned this pull request Oct 13, 2023
Open
@danielbankhead danielbankhead mentioned this pull request Oct 13, 2023
Closed
@danielbankhead danielbankhead mentioned this pull request Oct 17, 2023
Closed
aeitzman
aeitzman reviewed Oct 19, 2023
View reviewed changes
src/auth/authclient.ts Show resolved Hide resolved
src/auth/authclient.ts Outdated Show resolved Hide resolved
src/auth/authclient.ts Outdated Show resolved Hide resolved
src/auth/idtokenclient.ts Show resolved Hide resolved
test/test.util.ts Show resolved Hide resolved
samples/keepalive.js Outdated Show resolved Hide resolved
src/auth/baseexternalclient.ts Show resolved Hide resolved
@danielbankhead danielbankhead mentioned this pull request Oct 23, 2023
Open
@danielbankhead danielbankhead mentioned this pull request Oct 25, 2023
Open
@danielbankhead danielbankhead merged commit 5ac6705 into main Oct 26, 2023
15 checks passed
@danielbankhead danielbankhead deleted the authclient-enhancements branch October 26, 2023 22:58
@release-please release-please bot mentioned this pull request Oct 26, 2023
Merged
@ruyadorno ruyadorno mentioned this pull request Oct 30, 2023
Closed
@danielbankhead danielbankhead mentioned this pull request Jan 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeitzman aeitzman aeitzman approved these changes

Assignees
No one assigned
Labels
size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to configure Gaxios options for common AuthClients
3 participants
@danielbankhead @aeitzman @yoshi-kokoro