Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typos in samples #1728

Merged
merged 4 commits into from Jan 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 4 additions & 3 deletions samples/jwt.js
@@ -1,9 +1,10 @@
// Copyright 2017, Google, Inc.
// Copyright 2017 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
Expand All @@ -27,7 +28,7 @@ const {JWT} = require('google-auth-library');
const fs = require('fs');

async function main(
// Full path to the sevice account credential
// Full path to the service account credential
keyFile = process.env.GOOGLE_APPLICATION_CREDENTIALS
) {
const keys = JSON.parse(fs.readFileSync(keyFile, 'utf8'));
Expand Down
7 changes: 4 additions & 3 deletions samples/keyfile.js
@@ -1,9 +1,10 @@
// Copyright 2018, Google, LLC.
// Copyright 2018 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
Expand All @@ -22,7 +23,7 @@ const {GoogleAuth} = require('google-auth-library');
* Acquire a client, and make a request to an API that's enabled by default.
*/
async function main(
// Full path to the sevice account credential
// Full path to the service account credential
keyFile = process.env.GOOGLE_APPLICATION_CREDENTIALS
) {
const auth = new GoogleAuth({
Expand Down
2 changes: 1 addition & 1 deletion samples/scripts/externalclient-setup.js
Expand Up @@ -165,7 +165,7 @@ async function main(config) {
const awsAudience = `//iam.googleapis.com/${poolResourcePath}/providers/${awsProviderId}`;

// Allow service account impersonation.
// Get the existing IAM policity bindings on the current service account.
// Get the existing IAM policy bindings on the current service account.
response = await iam.projects.serviceAccounts.getIamPolicy({
resource: `projects/${projectId}/serviceAccounts/${clientEmail}`,
});
Expand Down
2 changes: 1 addition & 1 deletion samples/test/externalclient.test.js
Expand Up @@ -50,7 +50,7 @@
// AWS provider tests for AWS credentials
// -------------------------------------
// The test suite will also run tests for AWS credentials. This works as
// follows. (Note prequisite setup is needed. This is documented in
// follows. (Note prerequisite setup is needed. This is documented in
// externalclient-setup.js).
// - iamcredentials:generateIdToken is used to generate a Google ID token using
// the service account access token. The service account client_id is used as
Expand Down