fix: update code to support typescript@2.6.2 #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
@alexander-fenster for review as well |
alexander-fenster
approved these changes
Dec 19, 2017
|
@JustinBeckwith is the version of |
ofrobots
approved these changes
Dec 20, 2017
test/test.oauth2.ts
Outdated
| assert.equal(query.client_id, CLIENT_ID); | ||
| assert.equal(query.redirect_uri, REDIRECT_URI); | ||
| done(); | ||
| if (typeof parsed.query === 'string') { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
test/test.oauth2.ts
Outdated
|
|
||
| assert.equal(query.scope, SCOPE_ARRAY.join(' ')); | ||
| done(); | ||
| if (typeof parsed.query === 'string') { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
test/test.oauth2.ts
Outdated
|
|
||
| assert.equal(query.response_type, 'code'); | ||
| done(); | ||
| if (typeof parsed.query === 'string') { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
test/test.oauth2.ts
Outdated
| @@ -793,17 +803,25 @@ describe('OAuth2 client', () => { | |||
| new OAuth2Client(CLIENT_ID, CLIENT_SECRET, REDIRECT_URI); | |||
| const generated = oauth2client.generateAuthUrl({}); | |||
| const parsed = url.parse(generated); | |||
| const query = qs.parse(parsed.query); | |||
| assert.equal(query.redirect_uri, REDIRECT_URI); | |||
| if (typeof parsed.query === 'string') { | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
ofrobots
pushed a commit
that referenced
this pull request
Jan 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests for Node.js 4 and Node.js 6 randomly started failing due to what seems like a compiler change. Our
package-lock.jsonis pinning totypescript@2.6.1, which covers Node.js 8. The~2.6.0tag in ourpackage.jsonis letting new patch versions of typescript come through as designed, resulting intypescript@2.6.2getting installed. I suspect TypeScript made a breaking change in a patch release :(