Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: document proxy behavior and verify with a test #221

Merged
merged 2 commits into from
Dec 28, 2017
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,6 @@ main();
The parameters for the JWT auth client including how to use it with a `.pem` file are explained in [samples/jwt.js](samples/jwt.js).

#### Loading credentials from environment variables

Instead of loading credentials from a key file, you can also provide them using an environment variable and the `GoogleAuth.fromJSON()` method. This is particularly convenient for systems that deploy directly from source control (Heroku, App Engine, etc).

Start by exporting your credentials:
Expand Down Expand Up @@ -290,6 +289,13 @@ async function main() {

main().catch(console.error);
```
#### Using a Proxy
You can use the following environment variables to proxy HTTP and HTTPS requests:

- HTTP_PROXY / http_proxy
- HTTPS_PROXY / https_proxy

When HTTP_PROXY / http_proxy are set, they will be used to proxy non-SSL requests that do not have an explicit proxy configuration option present. Similarly, HTTPS_PROXY / https_proxy will be respected for SSL requests that do not have an explicit proxy configuration option. It is valid to define a proxy in one of the environment variables, but then override it for a specific request, using the proxy configuration option.

### Questions/problems?

Expand Down
40 changes: 39 additions & 1 deletion test/test.transporters.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*/

import * as assert from 'assert';
import {AxiosRequestConfig} from 'axios';
import {AxiosProxyConfig, AxiosRequestConfig} from 'axios';
import * as nock from 'nock';

import {DefaultTransporter, RequestError} from '../src/transporters';
Expand Down Expand Up @@ -98,4 +98,42 @@ describe('Transporters', () => {
done();
});
});

it('should use the http proxy if one is configured', async () => {

This comment was marked as spam.

This comment was marked as spam.

process.env['http_proxy'] = 'http://han:solo@proxy-server:1234';
const transporter = new DefaultTransporter();
nock('http://proxy-server:1234')
.get('http://example.com/fake', undefined, {
reqheaders: {
'host': 'example.com',
'accept': /.*/g,
'user-agent': /google-api-nodejs-client\/.*/g,
'proxy-authorization': /.*/g
}
})
.reply(200);
const url = 'http://example.com/fake';
const result = await transporter.request({url});
assert.equal(result.status, 200);
process.env['http_proxy'] = undefined;

This comment was marked as spam.

This comment was marked as spam.

});

it('should use the https proxy if one is configured', async () => {
process.env['https_proxy'] = 'https://han:solo@proxy-server:1234';
const transporter = new DefaultTransporter();
nock('https://proxy-server:1234')
.get('https://example.com/fake', undefined, {
reqheaders: {
'host': 'example.com',
'accept': /.*/g,
'user-agent': /google-api-nodejs-client\/.*/g,
'proxy-authorization': /.*/g
}
})
.reply(200);
const url = 'https://example.com/fake';
const result = await transporter.request({url});
assert.equal(result.status, 200);
process.env['https_proxy'] = undefined;
});
});