feat: allow passing maxExpiry to verifyIdToken #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: The parameters to the `verifyIdToken` method of
OAuth2Client have been changed. The function now accepts a single
options object, and an optional callback. A function that used
to look like this:
```js
oAuth2Client.verifyIdToken(idToken, audience, callback);
```
Would now be rewritten as this:
```js
oAuth2Client.verifyIdToken({
idToken: idToken,
audience: audience
}, callback);
```
googlebot
added
the
cla: yes
ofrobots
approved these changes
Jan 2, 2018
src/auth/oauth2client.ts
Outdated
| callback?: (err: Error|null, login?: LoginTicket|null) => void): | ||
| void|Promise<LoginTicket|null> { | ||
| // This funtion used to accept two arguments instead of an options object. | ||
| // Check the types to help users upgrade with less pain. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
ofrobots
pushed a commit
that referenced
this pull request
Jan 9, 2018
BREAKING CHANGE: The parameters to the `verifyIdToken` method of
OAuth2Client have been changed. The function now accepts a single
options object, and an optional callback. A function that used
to look like this:
```js
oAuth2Client.verifyIdToken(idToken, audience, callback);
```
Would now be rewritten as this:
```js
oAuth2Client.verifyIdToken({
idToken: idToken,
audience: audience
}, callback);
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #118