feat: emit an event when new tokens are obtained #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #341 +/- ##
==========================================
+ Coverage 94.72% 94.75% +0.02%
==========================================
Files 14 14
Lines 948 953 +5
Branches 195 196 +1
==========================================
+ Hits 898 903 +5
Misses 50 50
Continue to review full report at Codecov.
|
JustinBeckwith
requested review from
a team and
alexander-fenster
and removed request for
a team
src/auth/oauth2client.ts
Outdated
| @@ -551,6 +552,9 @@ export class OAuth2Client extends AuthClient { | |||
| ((new Date()).getTime() + (res.data.expires_in * 1000)); | |||
| delete (tokens as CredentialRequest).expires_in; | |||
| } | |||
|
|
|||
| this.emit('tokens', tokens); | |||
|
|
|||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
test/test.jwt.ts
Outdated
| let raisedEvent = false; | ||
| jwt.on('tokens', tokens => { | ||
| assert.equal(tokens.access_token, 'initial-access-token'); | ||
| raisedEvent = true; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
test/test.oauth2.ts
Outdated
|
|
||
| // ensure the tokens event is raised | ||
| client.on('tokens', tokens => { | ||
| assert.equal(tokens.access_token, 'abc123'); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
alexander-fenster
approved these changes
Apr 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we really have no way to tell users when their access_token was refreshed. Some people store these on the server across multiple requests, so giving them some way to know when it happens would be nice. Users are asking for this over in google-api-nodejs-client.
Resolves #340.