Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use key file when fetching project id #618

Merged
merged 6 commits into from Feb 8, 2019
Merged

fix: use key file when fetching project id #618

merged 6 commits into from Feb 8, 2019

Conversation

callmehiphop
Copy link
Contributor

@callmehiphop callmehiphop commented Feb 7, 2019 •
edited

Fixes #614

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 7, 2019
@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 8, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 8, 2019
callmehiphop
callmehiphop commented Feb 8, 2019
View reviewed changes
src/auth/googleauth.ts
const creds = await this.getClient();

if (creds && creds.projectId) {
return creds.projectId;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JustinBeckwith made a small amendment to your commit, let me know if you hate it!

@JustinBeckwith JustinBeckwith merged commit d273752 into master Feb 8, 2019
@stephenplusplus stephenplusplus deleted the dg--614 branch March 18, 2019 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@callmehiphop @JustinBeckwith @googlebot @kokoro-team