Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): add locale property to idtoken #974

Merged
merged 2 commits into from
Jun 16, 2020
Merged

fix(types): add locale property to idtoken #974

merged 2 commits into from
Jun 16, 2020

Conversation

JustinBeckwith
Copy link
Contributor

@JustinBeckwith JustinBeckwith commented Jun 14, 2020 •
edited

Fixes #973

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 14, 2020
@codecov
Copy link

codecov bot commented Jun 14, 2020 •
edited

Codecov Report

Merging #974 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #974      +/-   ##
==========================================
+ Coverage   92.88%   92.89%   +0.01%     
==========================================
  Files          19       19              
  Lines        4017     4023       +6     
  Branches      454      454              
==========================================
+ Hits         3731     3737       +6     
  Misses        286      286
Impacted Files Coverage Δ
src/auth/loginticket.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca9ddd8...a0ed860. Read the comment docs.

@JustinBeckwith JustinBeckwith added the automerge Merge the pull request once unit tests and other checks pass. label Jun 16, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit ebf9bed into master Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoe bcoe bcoe approved these changes

@alexander-fenster alexander-fenster Awaiting requested review from alexander-fenster

@sofisl sofisl Awaiting requested review from sofisl

Assignees
No one assigned
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TokenPayload missing locale
3 participants
@JustinBeckwith @bcoe @googlebot