Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes subscriber and middleware options #184

Merged
merged 2 commits into from
Jan 24, 2018
Merged

fixes subscriber and middleware options #184

merged 2 commits into from
Jan 24, 2018

Conversation

bshaffer
Copy link
Contributor

@bshaffer bshaffer commented Jan 22, 2018 •
edited

#183 + tests

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 22, 2018
@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jan 22, 2018
@bshaffer bshaffer mentioned this pull request Jan 22, 2018
Closed
@googleapis googleapis deleted a comment from googlebot Jan 22, 2018
@bshaffer
Copy link
Contributor Author

CLA should be fixed now

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jan 22, 2018
kaimallea
kaimallea reviewed Jan 22, 2018
View reviewed changes
tests/ApplicationDefaultCredentialsTest.php Outdated
$keyFile = __DIR__ . '/fixtures' . '/private.json';
putenv(ServiceAccountCredentials::ENV_VAR . '=' . $keyFile);

// simulate not being GCE by return 500

This comment was marked as spam.

Sign in to view

kaimallea
kaimallea reviewed Jan 22, 2018
View reviewed changes
tests/ApplicationDefaultCredentialsTest.php Outdated
$keyFile = __DIR__ . '/fixtures' . '/private.json';
putenv(ServiceAccountCredentials::ENV_VAR . '=' . $keyFile);

// simulate not being GCE by return 500

This comment was marked as spam.

Sign in to view

@bshaffer bshaffer merged commit 383ab84 into master Jan 24, 2018
@bshaffer bshaffer deleted the add-middleware-test branch January 24, 2018 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaimallea kaimallea kaimallea left review comments

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bshaffer @kaimallea @googlebot