Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for proxy-authorization header #347

Merged
merged 8 commits into from
Jun 25, 2021

Conversation

gabihodoroaga
Copy link
Contributor

Fixes #346

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 21, 2021
Copy link
Contributor

@bshaffer bshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! We do need tests for this though. If you're able to add them, great! Otherwise I'll try to find time to write some.

src/Middleware/ProxyAuthTokenMiddleware.php Outdated Show resolved Hide resolved
src/Subscriber/ProxyAuthTokenSubscriber.php Outdated Show resolved Hide resolved
src/ApplicationDefaultCredentials.php Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@gabihodoroaga
Copy link
Contributor Author

Thank you for review.
I implemented the changes.
I added unit tests. I skipped the tests related to the caching because this part is covered by the AuthTokenMiddlewareTest

Copy link
Contributor

@bshaffer bshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks amazing! Thank you so much for adding the tests!

tests/Middleware/ProxyAuthTokenMiddlewareTest.php Outdated Show resolved Hide resolved
@bshaffer bshaffer merged commit aaf2363 into googleapis:master Jun 25, 2021
@bshaffer
Copy link
Contributor

Congrats @gabihodoroaga for the Google Cloud PHP contribution of the year award :)

@gabihodoroaga
Copy link
Contributor Author

gabihodoroaga commented Jun 25, 2021 via email

@jhanley-com
Copy link

I was testing the Proxy-Authorization header yesterday (2021-08-17) and it does not work. I wrote up some details on Stack Overflow: https://stackoverflow.com/a/59297859/8016720 I would love feedback on a solution. I used both the CLI curl and the example in the PHP SDK: aaf2363

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for IAP Proxy-Authorization Header
3 participants