-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for proxy-authorization header #347
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! We do need tests for this though. If you're able to add them, great! Otherwise I'll try to find time to write some.
Thank you for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks amazing! Thank you so much for adding the tests!
Congrats @gabihodoroaga for the Google Cloud PHP contribution of the year award :) |
Thank you ***@***.*** *I'm more than happy to know that this will help
others in the future.
…On Fri, Jun 25, 2021 at 9:41 PM Brent Shaffer ***@***.***> wrote:
Congrats @gabihodoroaga <https://github.com/gabihodoroaga> for the Google
Cloud PHP contribution of the year award :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#347 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABLI5TIBILBSGSN34OCLH3TTUTLXXANCNFSM47CO6LKA>
.
|
I was testing the Proxy-Authorization header yesterday (2021-08-17) and it does not work. I wrote up some details on Stack Overflow: https://stackoverflow.com/a/59297859/8016720 I would love feedback on a solution. I used both the CLI curl and the example in the PHP SDK: aaf2363 |
Fixes #346