Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use hardcoded string 'python', when you mean sys.executable. #1233

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Do not use hardcoded string 'python', when you mean sys.executable. #1233

merged 1 commit into from
Feb 23, 2023

Conversation

mcepl
Copy link
Contributor

@mcepl mcepl commented Feb 22, 2023

Perhaps fixes #1120

@mcepl mcepl requested review from a team as code owners February 22, 2023 19:59
@clundin25 clundin25 added the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 22, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 22, 2023
@clundin25
Copy link
Contributor

Thank you for your contribution @mcepl !

Can you format your commit to fix: Do not use hardcoded string 'python', when you mean sys.executable to pass the conventional commits test?

@clundin25 clundin25 added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 23, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 23, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 23, 2023
@clundin25
Copy link
Contributor

Hi @mcepl please pull in the latest changes in main for the tests to pass. Alternatively you can give me write permissions to your fork.

@clundin25 clundin25 added the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 23, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 23, 2023
@clundin25 clundin25 added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 23, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 23, 2023
@clundin25 clundin25 merged commit 91ac8e6 into googleapis:main Feb 23, 2023
@release-please release-please bot mentioned this pull request Feb 23, 2023
Merged
@mcepl mcepl deleted the no-python3 branch February 24, 2023 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clundin25 clundin25 clundin25 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2.11.0: pytest is failing
3 participants
@mcepl @clundin25 @yoshi-kokoro