Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enforce constraints during unit tests #760

Merged
merged 1 commit into from
May 25, 2021

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented May 25, 2021

Drop explicit pin / constraint on urllib3: specific requests versions have very narrow pins, and ours is only likely to create conflicts.

Bump the requests lower bound to 2.20.0, the lowest version for which our tests pass once constraints are being checked.

Closes #759

Drop explicit pin / constraint on 'urllib3':  specific 'requests'
versions have very narrow pins, and ours is only likely to create
conflicts.

Bump the 'requests' lower bound to '2.20.0', the lowest version for
which our tests pass once constraints are being checked.

Closes #759
@tseaver tseaver requested a review from a team as a code owner May 25, 2021 15:27
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 25, 2021
Copy link
Contributor

@busunkim96 busunkim96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tseaver!

@busunkim96 busunkim96 merged commit 1a6496a into master May 25, 2021
@busunkim96 busunkim96 deleted the 759-enforce-constraints-in-unit-tests branch May 25, 2021 15:57
@@ -123,7 +132,7 @@ def cover(session):
"--cov=google.oauth2",
"--cov=tests",
"--cov=tests_async",
"--cov-report=",
"--cov-report=term-missing",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If lines aren't being covered, then the report should include them, so that the hapless developer can figure out why. I've never understood why that isn't the default behavior for the report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'testing/constraints-*.txt' not used
3 participants