Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: validate urls for external accounts #1031

Merged
merged 13 commits into from
May 3, 2022
Merged

fix: validate urls for external accounts #1031

merged 13 commits into from
May 3, 2022

Commits on Apr 22, 2022

  1. [Bug 193694420] adding validation of token url and service account im… 

    …personation url (#1)

[b-193694420] adding url validation for token url and service account impersonation url
  * adding coverage of empty hostname to invalid token url
  * Add more tests to enlarge the coverage
Co-authored-by: Jin Qin <qinjin@google.com>
    @BigTailWolf
    BigTailWolf committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    3c31c75 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into main

    @lsirac
    lsirac committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    b8b273a View commit details
    Browse the repository at this point in the history

  3. adding coverage for service account impersonate url validation

    @BigTailWolf
    BigTailWolf committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    5682255 View commit details
    Browse the repository at this point in the history

  4. using urllib3 instead of urllib since it's the project test requireme… 

    …nts included
    @BigTailWolf
    BigTailWolf committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    d5beae7 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2022

  1. fix format

    @BigTailWolf
    BigTailWolf committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    32f0c9e View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2022

  1. addressing comments

    @BigTailWolf
    BigTailWolf committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    ba78e44 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2022

  1. remove redundant

    @BigTailWolf
    BigTailWolf committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    9c68168 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2022

  1. fix tests since python 3.6 cannot have same string constants interpre… 

    …t as 3.7+
    @BigTailWolf
    BigTailWolf committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    89ed17e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into main

    @lsirac
    lsirac committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    b14b004 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2022

  1. fix lint and fix the flaky test in an alternate way

    @BigTailWolf
    BigTailWolf committed May 2, 2022
    Configuration menu
    Copy the full SHA
    4840ffa View commit details
    Browse the repository at this point in the history

  2. revert the debugging output

    @BigTailWolf
    BigTailWolf committed May 2, 2022
    Configuration menu
    Copy the full SHA
    e2ff166 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2022

  1. fix lint

    @BigTailWolf
    BigTailWolf committed May 3, 2022
    Configuration menu
    Copy the full SHA
    c2e204e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into main

    @arithmetic1728
    arithmetic1728 committed May 3, 2022
    Configuration menu
    Copy the full SHA
    7748a13 View commit details
    Browse the repository at this point in the history