Fix issue where GAE Signer erroneously returns a tuple from sign() #109

theacodes · 2017-02-15T23:16:15Z

google/auth/app_engine.py

+        .. note::
+           This makes a request to the App Identity service.
+        """
+        key_id, _ = app_identity.sign_blob(b'')


tests/test_app_engine.py

@@ -41,6 +41,28 @@ def test_get_project_id_missing_apis():
    assert excinfo.match(r'App Engine APIs are not available')


+class TestSigner(object):
+    def test_key_id(self, app_identity_mock):


Fix issue where GAE Signer erroneously returns a tuple from sign()

21a95b6

theacodes requested review from lukesneeringer and dhermes February 15, 2017 23:16

dhermes reviewed Feb 15, 2017

View reviewed changes

dhermes mentioned this pull request Feb 15, 2017

Add IAM signer #108

Merged

lukesneeringer approved these changes Feb 16, 2017

View reviewed changes

theacodes merged commit 5b4e9c8 into master Feb 16, 2017

theacodes deleted the fix-gae-signer branch February 16, 2017 00:44

theacodes mentioned this pull request Feb 16, 2017

Consider allowing Signer.key_id to be None #112

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix issue where GAE Signer erroneously returns a tuple from sign() #109

Fix issue where GAE Signer erroneously returns a tuple from sign() #109

theacodes commented Feb 15, 2017

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

Fix issue where GAE Signer erroneously returns a tuple from sign() #109

Fix issue where GAE Signer erroneously returns a tuple from sign() #109

Conversation

theacodes commented Feb 15, 2017

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.