Add google.oauth2._client #13

theacodes · 2016-10-07T21:24:42Z

(branch name unrelated)

theacodes · 2016-10-07T21:27:54Z

Context: this will be used by oauth2.0-based credentials:

https://github.com/GoogleCloudPlatform/google-auth-library-python/blob/prototype/google/oauth2/service_account.py#L257

https://github.com/GoogleCloudPlatform/google-auth-library-python/blob/prototype/google/oauth2/credentials.py#L76

Having the grants implemented in one place vastly simplifies the credential implementations and makes it far easy to cover in tests.

google/oauth2/_client.py

+            error_data['error'],
+            error_data.get('error_description')])
+    # If not details could be extracted, use the response data.
+    except (KeyError, ValueError):


google/oauth2/_client.py

+            specified.
+    """
+    expires_in = response_data.get('expires_in', None)
+    if expires_in:


google/oauth2/_client.py

+        return _helpers.utcnow() + datetime.timedelta(
+            seconds=expires_in)
+    else:
+        return None


google/oauth2/_client.py

+    """
+    body = urllib.parse.urlencode(body)
+    headers = {
+        'content-type': 'application/x-www-form-urlencoded',


google/oauth2/_client.py

+    response = request(
+        method='POST', url=token_uri, headers=headers, body=body)
+
+    response_body = response.data.decode('utf-8')


google/oauth2/_client.py

+
+    response_data = _token_endpoint_request(request, token_uri, body)
+
+    access_token = response_data['access_token']


tests/oauth2/test__client.py

+import json
+
+import mock
+import pytest


tests/oauth2/test__client.py

+def test__handle_error_response():
+    response_data = json.dumps({
+        'error': 'help',
+        'error_description': 'I\'m alive'})


tests/oauth2/test__client.py

+    with pytest.raises(exceptions.RefreshError) as excinfo:
+        _client._handle_error_response(response_data)
+
+    assert excinfo.match(r'help: I\'m alive')


tests/oauth2/test__client.py

+    assert _client._parse_expiry({}) is None
+
+
+def test__token_endpoint_request():


dhermes · 2016-10-07T22:30:49Z

LGTM

Add google.oauth2._client

780b5bd

theacodes added this to the 1.0.0 milestone Oct 7, 2016

theacodes assigned bjwatson and dhermes Oct 7, 2016

dhermes reviewed Oct 7, 2016

View reviewed changes

Address review comments

f01db6b

theacodes merged commit 123a48b into master Oct 7, 2016

theacodes deleted the oauth2client branch October 7, 2016 22:33

theacodes mentioned this pull request Oct 21, 2016

1.0.0 Roadmap #3

Closed

12 tasks

theacodes unassigned bjwatson and dhermes Oct 11, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add google.oauth2._client #13

Add google.oauth2._client #13

theacodes commented Oct 7, 2016

theacodes commented Oct 7, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

dhermes commented Oct 7, 2016


		response_data = _token_endpoint_request(request, token_uri, body)

		access_token = response_data['access_token']

		assert _client._parse_expiry({}) is None


		def test__token_endpoint_request():

Add google.oauth2._client #13

Add google.oauth2._client #13

Conversation

theacodes commented Oct 7, 2016

theacodes commented Oct 7, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

dhermes commented Oct 7, 2016